fix(MultipartBodyWithJSON): form file field name format #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the format of form field name for a file.
FedorLap2006
added
the
fix
|
Whoops, forgot to push the local changes. It's |
Use files[n] instead of file[n] in the form field name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
MultipartBodyWithJSONusesfile<index>format for thenameof the form field for files. However this format is not correct, according to the documentation. The correct format isfiles[<index>].The implementation was working all that time, because all the endpoints with support of attachments append them automatically and you do not need to reference them, however when you would try to, you would just get an "Unknown attachment" error.
This PR should fix this problem.
Initially I discovered this when I was performing manual tests on #1253.