Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structs): fix type of GuildScheduledEvent* enum values #1254

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

invakid404
Copy link
Contributor

@invakid404 invakid404 commented Oct 1, 2022

Seems like the types of the enum values of GuildScheduledEventStatus and
GuildScheduledEventEntityType were overlooked and were left as int,
resulting in the need to cast them each time you want to use them.

@FedorLap2006 FedorLap2006 self-requested a review October 2, 2022 13:40
@FedorLap2006 FedorLap2006 added the breaking changes Contains breaking changes. Should be reflected in the changelog label Oct 2, 2022
@todortotev
Copy link

@FedorLap2006 how is that supposed to be a breaking change?

@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Oct 4, 2022

@FedorLap2006 how is that supposed to be a breaking change?

It's not a breaking change, you are right. My bad

@FedorLap2006 FedorLap2006 added fix Pull requests and issues related to bug fixes and structural inconsistencies and removed breaking changes Contains breaking changes. Should be reflected in the changelog labels Oct 4, 2022
@FedorLap2006 FedorLap2006 merged commit bb32127 into bwmarrin:master Oct 7, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@invakid404 invakid404 deleted the fix/enums branch October 7, 2022 11:48
LWCoder pushed a commit to AtTheTavern/discordgo that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests and issues related to bug fixes and structural inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants