code128: reduce extended latch cut-off from 5 to 4 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latch/unlatch extended on 4 chars instead of 5 for better encodation in certain cases (and no pessimizations found so far), part addresses PR #272, props lyngklip Also fix masked extended chars matching ASCII digits in `numsscr` (skipped using re-synced `numEA` array)
|
Closing in favour of PR #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latch/unlatch extended on 4 chars instead of 5 for better
encodation in certain cases (and no pessimizations found so far),
part addresses PR #272, props lyngklip
Also fix masked extended chars matching ASCII digits in
numsscr(skipped using re-synced
numEAarray)This is the first of two alternative PRs, the second one being
an implementation of Alex Geller's divide & conquer algorithm as
used by ZXing (and Zint)