Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear row/column counts with CMC.ClearAll #796

Merged
merged 2 commits into from
Aug 31, 2017

Conversation

tcosentino
Copy link
Contributor

Thanks for contributing to react-virtualized!

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Run tests locally (npm test) to ensure that your change did not break linting or functionality.
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Let me know if this test is sufficient. I can do something more in depth that illustrates the error I was seeing too if needed.

@bvaughn bvaughn merged commit 6cf3e44 into bvaughn:master Aug 31, 2017
@bvaughn
Copy link
Owner

bvaughn commented Aug 31, 2017

Thanks 😄

@bvaughn
Copy link
Owner

bvaughn commented Sep 18, 2017

This feature has been released in version 9.10.0. Thank you for contributing!

@tcosentino
Copy link
Contributor Author

tcosentino commented Sep 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants