-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add onWheel prop #778
add onWheel prop #778
Conversation
I'm not sure I want to expose a "wheel" event handler on |
Well, without the ability to force react-virtualized to run wheel events synchronously, react-virtualized has huge tearing issues in electron. We talked about this previously, what would you suggest we do now? |
This is where we left off last time, we haven't had the need to update react-virtualized in awhile, but we're planning on updating react-virtualized, soon. Before we can update react-virtualized, we need to make sure that we can fix the tearing that occurs in multiple grid scrolling. Since this seemed to be the direction we wanted to go last time, if it's no longer the direction you intend, what do we do now? |
Don't know. Need to think about it. Not immediately comfortable with encouraging usage of "wheel" events (with an explicit Maybe some kind of rest prop that just lets you pass through unfiltered properties to the root You're right that I mentioned |
I'll revise for a rest prop. |
d87aeac
to
437bd5f
Compare
Also was looking for an |
Nevermind, I should be able to solve it when this is released. |
This feature has been released in version 9.10.0. Thank you for contributing! |
This is a follow up to #541.
The PR simply exposes the onWheel prop for Grid.