Re-added :key for Grid children but used a 0-based key instead of a r…

…ows+column key.
bvaughn · Feb 22, 2016 · d644396 · d644396
1 parent f31a18c
commit d644396
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/dist/react-virtualized.js b/dist/react-virtualized.js
diff --git a/dist/react-virtualized.js.map b/dist/react-virtualized.js.map
diff --git a/es/Grid/Grid.js b/es/Grid/Grid.js
@@ -377,6 +377,8 @@ var Grid = (_temp = _class = function (_Component) {
         rowStartIndex = overscanRowIndices.overscanStartIndex;
         rowStopIndex = overscanRowIndices.overscanStopIndex;
 
+        var key = 0;
+
         for (var rowIndex = rowStartIndex; rowIndex <= rowStopIndex; rowIndex++) {
           var rowDatum = this._rowMetadata[rowIndex];
 
@@ -388,7 +390,7 @@ var Grid = (_temp = _class = function (_Component) {
             child = _react2.default.createElement(
               'div',
               {
-                key: 'row:' + rowIndex + ', column:' + columnIndex,
+                key: ++key,
                 className: 'Grid__cell',
                 style: {
                   transform: transform,

diff --git a/source/Grid/Grid.example.js b/source/Grid/Grid.example.js
@@ -148,6 +148,7 @@ export default class GridExample extends Component {
               height={height}
               noContentRenderer={this._noContentRenderer}
               overscanColumnsCount={overscanColumnsCount}
+              overscanRowsCount={overscanRowsCount}
               renderCell={this._renderCell}
               rowHeight={useDynamicRowHeight ? this._getRowHeight : rowHeight}
               rowsCount={rowsCount}

diff --git a/source/Grid/Grid.js b/source/Grid/Grid.js
@@ -425,6 +425,8 @@ export default class Grid extends Component {
       rowStartIndex = overscanRowIndices.overscanStartIndex
       rowStopIndex = overscanRowIndices.overscanStopIndex
 
+      let key = 0
+
       for (let rowIndex = rowStartIndex; rowIndex <= rowStopIndex; rowIndex++) {
         let rowDatum = this._rowMetadata[rowIndex]
 
@@ -435,6 +437,7 @@ export default class Grid extends Component {
 
           child = (
             <div
+              key={++key}
               className='Grid__cell'
               style={{
                 transform,