fix: use ResizeObserver global from parentNode realm to support case with multiple realms #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with multiple realms
bvaughn
reviewed
Feb 21, 2024
This logic happens in
Yeah, can confirm that:
|
That's fair. (The issue the comment referred to is bvaughn/react-virtualized#41 FWIW) |
|
Thank you! |
hoxyq
added a commit
to facebook/react
that referenced
this pull request
Feb 22, 2024
…-auto-sizer to ^1.0.23 (#28408) 1. Bumps `react-virtualized-auto-sizer` to 1.0.23, which has a fix for cases with multiple realms - bvaughn/react-virtualized-auto-sizer#82 2. Removes `react-window` from react-devtools-shared/src/node_modules, now listed as dependency in `package.json` and bumped to 1.8.10 Tested: - Chrome extension - Standalone shell with RN
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…-auto-sizer to ^1.0.23 (facebook#28408) 1. Bumps `react-virtualized-auto-sizer` to 1.0.23, which has a fix for cases with multiple realms - bvaughn/react-virtualized-auto-sizer#82 2. Removes `react-window` from react-devtools-shared/src/node_modules, now listed as dependency in `package.json` and bumped to 1.8.10 Tested: - Chrome extension - Standalone shell with RN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on something for React DevTools, which requires us to start using
ResizeObserver. After bumping this package to version1.0.22, theonResizecallback has stopped being executed in valid cases for the browser extension.After some debugging, I've noticed that the
parentNode.ownerDocumentis different fromdocument, which means that the code runs in a different realm from whereparentNodewas defined.By running
I've checked
documentandResizeObserverinstances, this is the result:Essentially, this change is only about switching
ResizeObservertoparentNode.ownerDocument.defaultView.ResizeObserver.Happy to provide more context if needed, tried adding a test for it with some iframes, but this will probably take much more time than the change itself.