feat(Support SVG elements on modals): expand utils for stacking order to include SVGElements #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gatzjames
changed the title
|
Thanks! Sorry I didn't notice this. |
|
Published as [email protected] ❤️ → ☕ givebrian.coffee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
When hovering over SVG icons on elements "above" a handle (e.g. modal) the resize cursor appears and users can drag it to resize the panels "bellow".
Suggested solution:
Expand the
recalculateIntersectingHandlesfunction to includeSVGElementwhen looking at the stacking order of elements which fire pointer events.