Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read "direction" from the document; use inherited style instead #424

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

bvaughn
Copy link
Owner

@bvaughn bvaughn commented Oct 27, 2024

cc @mohas

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 2:05pm

@bvaughn
Copy link
Owner Author

bvaughn commented Oct 27, 2024

Ideally I would add some unit tests for this but JSDom doesn't support either dir nor inherited styles, so the tests wouldn't be very valuable.

I could add some e2e tests for this but it would kind of be a hassle and I'm not sure it's complex enough to warrant the hassle.

@bvaughn bvaughn merged commit 8ea2424 into main Oct 27, 2024
7 checks passed
@bvaughn bvaughn deleted the better-rtl-support branch October 27, 2024 14:07
@bvaughn
Copy link
Owner Author

bvaughn commented Oct 27, 2024

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant