Prevent pointer events from triggering on elements behind hitAreaMargins #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4nnikaf
changed the title
4nnikaf
changed the title
bvaughn
approved these changes
Apr 15, 2024
| y: event.clientY, | ||
| }; | ||
| } | ||
| } else if (isMouseEvent(event)) { |
| @@ -89,6 +89,7 @@ function handlePointerDown(event: ResizeEvent) { | |||
| updateResizeHandlerStates("down", event); | |||
|
|
|||
| event.preventDefault(); | |||
| event.stopPropagation(); | |||
There was a problem hiding this comment.
This is the only change that gives me pause. I guess it's okay.
|
Thanks for the PR. I'm preparing a release in #339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a problem described in #336
To solve the issue of click events passing through the hitAreaMargins to the elements behind them all we need to do is handle the events in the capture phase and prevent them from bubbling down to the children/panel content by calling
event.stopPropagation().However cancelling the mouse/touch events (for exmaple
mousedown/touchstart), does not cancel their pointer event counterparts (pointerdown), like it does the other way around. So I also changed the event handlers to listen to the pointer events instead.