Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional panel positions #8

Closed
bvaughn opened this issue Dec 23, 2022 · 0 comments · Fixed by #9
Closed

Conditional panel positions #8

bvaughn opened this issue Dec 23, 2022 · 0 comments · Fixed by #9
Labels
bug Something isn't working

Comments

@bvaughn
Copy link
Owner

bvaughn commented Dec 23, 2022

PanelGroup infers panel positions based on the order panels are registered in. Conditional rendering can "break" this, as panels registered after mount will be added to the end of the container.

There needs to be a way for panels to specify their ordering via a prop. This prop could be optional for cases when there is no conditional rendering.
@bvaughn bvaughn added the bug Something isn't working label Dec 23, 2022
@bvaughn bvaughn mentioned this issue Dec 23, 2022
Merged
bvaughn added a commit that referenced this issue Dec 23, 2022
@bvaughn
Merge pull request #9 from /issues/8
62ce622 
Add :order prop to Panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add :order prop to Panel bvaughn/react-resizable-panels
1 participant
@bvaughn