Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelResizeHandle: Auto-calculate before/after Panel ids #5

Closed
bvaughn opened this issue Dec 23, 2022 · 2 comments
Closed

PanelResizeHandle: Auto-calculate before/after Panel ids #5

bvaughn opened this issue Dec 23, 2022 · 2 comments
Assignees
@bvaughn

Comments

@bvaughn
Copy link
Owner

bvaughn commented Dec 23, 2022

I think PanelGroup should be able to infer this based on the order of registered panels/drag-handles.

Might this get tricky with the changes in #3? Not sure.
@bvaughn bvaughn self-assigned this Dec 23, 2022
@bvaughn
Copy link
Owner Author

bvaughn commented Dec 23, 2022

This might be trickier than I had assumed, because of #3.

The visual "order" of Panels can't necessarily be inferred based on their registration sequence. If a Panel is toggled on somewhere in the middle of the group, it may register after a "later" panel does.

@bvaughn
Copy link
Owner Author

bvaughn commented Dec 23, 2022

Maybe the order prop (added in 0.0.4) would be sufficient to solve the above issue.

bvaughn added a commit that referenced this issue Dec 23, 2022
@bvaughn
Merge pull request #10 from /issues/5
eaf76f1 
Remove panelBefore/panelAfter prop requirements from resize handle
@bvaughn bvaughn closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvaughn