Examples on website are broken

[timdown]

Firstly, thanks for finishing the pixel size work, which looks promising. However, I think there are some rough edges in 0.0.56. I've noticed the following problems with the examples on the website, some of which I've also seen on the application I'm working on:

• All pages: resizing seems to snap only to the maximum or minimum size (at least in most cases)
• Collapsible panels: the resizer seems to be stuck on the right-hand side
• Pixel-based layouts: resizers have no effect

Additionally, there's an error when calling expand() or collapse() on a panel via the imperative API in an effect that runs after first render:

https://codesandbox.io/s/lively-surf-jq5pzc?file=/src/App.js

[bvaughn]

Oh that's embarrassing. I probably broke something by making a last minute change yesterday for the e2e test. 🤡

Interestingly, the bug doesn't repro locally (localhost running the latest version of main).

• Replay of localhost (works): 9dd0a54c-980f-47a5-9c64-87c12c3fc7a5
• Replay of production (broken): b3a8ead1-5a00-40c2-a2bd-567effeb188e
• Replay of my staging branch: 101720ff-a54e-4e52-9ee7-92b9d6cc596e

I'll add comments to those Replays to see if I can spot the difference.

[bvaughn]

Ah! The problem is that I'm rendering the data-panel-group-id attribute conditionally (dev only) for PanelGroup. Wow what an oversight.

[bvaughn]

Thanks so much for reporting this issue. I think it's been fixed in 0.0.57. (There may be other regressions related to the large rewrite, but at least the one you reported has been resolved.)

---

❤️ → ☕ givebrian.coffee

[timdown]

Ah! The problem is that I'm rendering the data-panel-group-id attribute conditionally (dev only) for PanelGroup. Wow what an oversight.

Hey, we've all done that kind of thing 😄 Thanks for fixing it so quickly. I'll let you know if I find anything else.

[bvaughn]

Thanks!

[timdown]

I'm still seeing the expand()/collapse() issue: https://codesandbox.io/s/gracious-cannon-h5stq4. I guess it's a slightly odd thing to be expanding or collapsing a panel straight after the initial render, but it worked in previous versions.

[bvaughn]

I've filed a new issue for that (#211)