Small bug fix to guard against saving an incorrect panel layout to lo…

…cal storage
bvaughn · Dec 13, 2023 · ab496d8 · ab496d8 · vercel · Dec 13, 2023
1 parent bce573c
commit ab496d8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/react-resizable-panels/CHANGELOG.md b/packages/react-resizable-panels/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
-## 1.0.0
+## 1.0.1
+
+- Small bug fix to guard against saving an incorrect panel layout to local storage
+
+# 1.0.0
 
 - Remove support for pixel-based Panel constraints; (props like `defaultSizePercentage` should now be `defaultSize`)
 - Replaced `dataAttributes` prop with `...rest` prop that supports all HTML attributes

diff --git a/packages/react-resizable-panels/package.json b/packages/react-resizable-panels/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-resizable-panels",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "React components for resizable panel groups/layouts",
   "author": "Brian Vaughn <[email protected]>",
   "license": "MIT",

diff --git a/packages/react-resizable-panels/src/PanelGroup.ts b/packages/react-resizable-panels/src/PanelGroup.ts
@@ -225,7 +225,9 @@ function PanelGroupWithForwardedRef({
         debounceMap[autoSaveId] = debouncedSave;
       }
 
-      debouncedSave(autoSaveId, panelDataArray, layout, storage);
+      // Clone panel data array before saving since this array is mutated.
+      // If we don't clone, we run the risk of saving the wrong panel and layout pair.
+      debouncedSave(autoSaveId, [...panelDataArray], layout, storage);
     }
   }, [autoSaveId, layout, storage]);