Removed nullish coalescing operator (??)

It caused problems with default create-react-app configuration.
bvaughn · Jan 10, 2023 · 8677dab · 8677dab
1 parent d837524
commit 8677dab
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/packages/react-resizable-panels-website/src/routes/examples/Collapsible.tsx b/packages/react-resizable-panels-website/src/routes/examples/Collapsible.tsx
@@ -43,7 +43,7 @@ function Content() {
 
   const { currentFileIndex, fileListCollapsed, openFiles } = state;
 
-  const currentFile = openFiles[currentFileIndex] ?? null;
+  const currentFile = openFiles[currentFileIndex] || null;
 
   const closeFile = (file: File) => {
     dispatch({ type: "close", file });

diff --git a/packages/react-resizable-panels-website/src/suspense/SyntaxParsingCache.ts b/packages/react-resizable-panels-website/src/suspense/SyntaxParsingCache.ts
@@ -260,7 +260,7 @@ function processSection(
   section: string,
   className: string
 ) {
-  const tokenType = className?.substring(4) ?? null; // Remove "tok-" prefix;
+  const tokenType = className?.substring(4) || null; // Remove "tok-" prefix;
 
   let index = 0;
   let nextIndex = section.indexOf("\n");

diff --git a/packages/react-resizable-panels/CHANGELOG.md b/packages/react-resizable-panels/CHANGELOG.md
@@ -1,8 +1,8 @@
 # Changelog
 
 ## 0.0.31
-* [#71](https://github.com/bvaughn/react-resizable-panels/pull/71): Added `getSize` and `getCollapsed` to imperative API exposed by `Panel`.
-
+* [#71](https://github.com/bvaughn/react-resizable-panels/issues/71): Added `getSize` and `getCollapsed` to imperative API exposed by `Panel`.
+* [#67](https://github.com/bvaughn/react-resizable-panels/issues/67), [#72](https://github.com/bvaughn/react-resizable-panels/issues/72): Removed nullish coalescing operator (`??`) because it caused problems with default create-react-app configuration.
 ## 0.0.30
 * [#68](https://github.com/bvaughn/react-resizable-panels/pull/68): Reduce volume/frequency of local storage writes for `PanelGroup`s configured to _auto-save_.
 * Added `onLayout` prop to `PanelGroup` to be called when group layout changes. Note that some form of debouncing is recommended before processing these values (e.g. saving to a database).

diff --git a/packages/react-resizable-panels/src/utils/group.ts b/packages/react-resizable-panels/src/utils/group.ts
@@ -182,7 +182,7 @@ export function getResizeHandleIndex(id: string): number | null {
   const index = handles.findIndex(
     (handle) => handle.getAttribute("data-panel-resize-handle-id") === id
   );
-  return index ?? null;
+  return index || null;
 }
 
 export function getResizeHandles(): HTMLDivElement[] {
@@ -206,8 +206,8 @@ export function getResizeHandlePanelIds(
   const handles = getResizeHandlesForGroup(groupId);
   const index = handles.indexOf(handle);
 
-  const idBefore: string | null = panelsArray[index]?.id ?? null;
-  const idAfter: string | null = panelsArray[index + 1]?.id ?? null;
+  const idBefore: string | null = panelsArray[index]?.id || null;
+  const idAfter: string | null = panelsArray[index + 1]?.id || null;
 
   return [idBefore, idAfter];
 }

diff --git a/packages/react-resizable-panels/src/utils/serialization.ts b/packages/react-resizable-panels/src/utils/serialization.ts
@@ -39,7 +39,7 @@ export function loadPanelLayout(
   const state = loadSerializedPanelGroupState(autoSaveId);
   if (state) {
     const key = getSerializationKey(panels);
-    return state[key] ?? null;
+    return state[key] || null;
   }
 
   return null;