Update withErrorBoundary types for forwards compat

[henryqdineen]

What:

This PR updates the withErrorBoundary() to work with newer versions of @types/react

Why:

In @types/[email protected] (original PR) there was a change published to the forwardRef type that is incompatible with withErrorBoundary. It results in this error:

Argument of type '(props: Props, ref: ForwardedRef<ComponentType<Props>>) => React.CElement<ErrorBoundaryProps, ErrorBoundary>' is not assignable to parameter of type 'ForwardRefRenderFunction<ComponentType<Props>, PropsWithoutRef<Props>>'.
  Types of parameters 'props' and 'props' are incompatible.
    Type 'PropsWithoutRef<Props>' is not assignable to type 'Props'.
      'PropsWithoutRef<Props>' is assignable to the constraint of type 'Props', but 'Props' could be instantiated with a different subtype of constraint 'object'.
        Type 'object' is not assignable to type 'Props'.
          'object' is assignable to the constraint of type 'Props', but 'Props' could be instantiated with a different subtype of constraint 'object'.ts(2345)

My understanding is that the props argument of the forwardRef callback expects to not have a ref property but the Props extends Object constraint does not guarantee that. I initially tried to just remove the type annotation on the props argument so it will be inferred as React.PropsWithoutRef<Props> but I ran into other errors like Argument of type 'PropsWithoutRef<Props> & { ref: ForwardedRef<ComponentType<Props>>; }' is not assignable to parameter of type '(Attributes & Props) | null | undefined'.

My solution here to was refactor a bit and make the withErrorBoundary HOC be parameterized by the component type instead of props type. I also fixed the implementation to use ComponentRef<> since the ref will not always be a ComponentType<>. I believe this will be a breaking TypeScript change to anybody providing a type argument to withErrorBoundary() and the return type will be different.

How:

Checklist:

• Documentation
• Tests
• Ready to be merged
  

[bvaughn]

I think this change is okay, though it sounds like I'll need to make a new major release since it's backwards breaking. I appreciate the contribution and the explanation.

[bvaughn]

Published in version 5.0.0

[httpete-broadcom]

Really should notify folks to update their @types/react to 18.3.18 or higher.