Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types.ts): remove unnecessary declare function FallbackRender #204

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Oct 28, 2024

What:

  • remove unnecessay declare function FallbackRender

Why:

  • declare is only necessary for external modules or global scope.
    • using declare for internally used functions or types is unnecessary.
    • if the function is not provided externally, it is clearer to define it explicitly.
  • improved code consistency and readability.
    • by removing unnecessary declare keywords, the code becomes more concise and maintains a consistent structure.
    • directly defining function types reduces confusion between implementation and declaration.

How:

  • ensuring consistency between types and implementation.
    • by removing declare and managing type definitions alongside implementations, it prevents inconsistencies between types and actual behavior.
    • code changes ensure that type definitions and implementations are updated together, enhancing maintainability.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@bvaughn bvaughn merged commit 0a10d4c into bvaughn:master Oct 28, 2024
3 checks passed
@sukvvon sukvvon deleted the refactor/remove-delcare-function branch October 28, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants