ci(eslint): use eslint+prettier with ci strictly #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manudeli
commented
Aug 12, 2023
| @@ -0,0 +1 @@ | |||
| dist | |||
There was a problem hiding this comment.
Ignore eslint rule in built source
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| command: ['pnpm lint', 'pnpm typescript', 'pnpm test'] |
There was a problem hiding this comment.
All quality check concurrently in single file
|
@bvaughn Could I get your review for this Pull Request? |
bvaughn
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: use eslint+prettier with ci strictly
Why: strict auto format with eslint+prettier will make us maintain code quality easily. After setup like this, I want to make sure my code quality with more strict eslint rule before commiting in my local machine, not after GitHub Action with loose prettier rule on pr opened
How: eslint+prettier setup, use it in ci.yml
Checklist: