Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax uuid dependency #25

Closed
wants to merge 1 commit into from
Closed

Relax uuid dependency #25

wants to merge 1 commit into from

Conversation

jeremyzahner
Copy link

@jeremyzahner jeremyzahner commented Aug 5, 2019

This PR should solve various problems within earlier versions of uuid.

Example: uuidjs/uuid#252

@bvaughn
Copy link
Owner

bvaughn commented Aug 5, 2019

Did you test this?

This library uses the uuid package like so:

import uuid from "uuid";

uuid.v4();

The docs for v3 of the uuid package show usage as:

const uuidv4 = require('uuid/v4');
uuidv4();

Those don't look compatible.

@jeremyzahner
Copy link
Author

jeremyzahner commented Aug 8, 2019

@bvaughn Yes. Technically, it still works for v2 and v3 of the uuid package. It is deprecated thou.

[Deprecation warning: The use of require('uuid') is deprecated and will not be supported after version 3.x of this module. Instead, use require('uuid/[v1|v3|v4|v5]') as shown in the examples below.]

We could change the usage now. This would break compatibility with v2 (of uuid).

@bvaughn bvaughn closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants