Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow set self signed certs #59

Merged
merged 3 commits into from
Aug 23, 2024
Merged

allow set self signed certs #59

merged 3 commits into from
Aug 23, 2024

Conversation

jlvcm
Copy link
Contributor

@jlvcm jlvcm commented Aug 22, 2024

No description provided.

actual/api/__init__.py Outdated Show resolved Hide resolved
@bvanelli
Copy link
Owner

Tests are also failing, try:

diff --git a/tests/test_api.py b/tests/test_api.py
index e16805e..402b28d 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -33,6 +33,7 @@ def test_rename_delete_budget_without_file():
 @patch("requests.post", return_value=RequestsMock({"status": "error", "reason": "proxy-not-trusted"}))
 def test_api_login_unknown_error(_post):
     actual = Actual.__new__(Actual)
+    actual.cert = True
     actual.api_url = "localhost"
     with pytest.raises(AuthorizationError, match="Something went wrong on login"):
         actual.login("foo")

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.95%. Comparing base (31f0e5d) to head (2c259c0).
Report is 1 commits behind head on main.

Files Patch % Lines
actual/api/__init__.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          13       13           
  Lines        1838     1839    +1     
=======================================
+ Hits         1782     1783    +1     
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit 0762863 into bvanelli:main Aug 23, 2024
6 of 7 checks passed
@bvanelli
Copy link
Owner

Merged, will come on the next release.

Thanks for your contribution.

@jlvcm jlvcm deleted the feature-cert branch August 26, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants