Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

no-empty-character-class false positive with unicode regexps #289

Open
Jessidhia opened this issue Feb 8, 2018 · 4 comments
Open

no-empty-character-class false positive with unicode regexps #289

Jessidhia opened this issue Feb 8, 2018 · 4 comments
Labels
accepting pr's bug needs investigation nice first contribution

Comments

@Jessidhia
Copy link

Any regular expression with u in their flags causes the warning.

image

Presumably the same will happen when typescript gets support for s in the flags (dotAll).
@buzinas
Copy link
Owner

buzinas commented Feb 25, 2018

Hey @Kovensky, thanks for reporting the problem. This issue shouldn't be too hard to fix, would you open a PR for that?

@ilan-schemoul
Copy link

Same goes for s

soulthreads added a commit to soulthreads/tslint-eslint-rules that referenced this issue Oct 3, 2018
@soulthreads
Allow unicode regexes in no-empty-character-class (buzinas#289)
cdd9fad
soulthreads added a commit to soulthreads/tslint-eslint-rules that referenced this issue Oct 3, 2018
@soulthreads
[bug] fixed no-empty-character-class rule (closes buzinas#289)
f38c6c8
vvscode added a commit to vvscode/tslint-eslint-rules that referenced this issue Mar 8, 2019
@vvscode
no-empty-character-class false positive with unicode regexps buzinas#289
4c0ee48
@vvscode vvscode mentioned this issue Mar 8, 2019
Open
@vvscode
Copy link

vvscode commented Mar 10, 2019

@buzinas friendly ping )

@xiaojian-hong xiaojian-hong mentioned this issue Sep 5, 2020
Merged
@danielemonaca
Copy link

Is this still relevant?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting pr's bug needs investigation nice first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Jessidhia @vvscode @buzinas @ilan-schemoul @danielemonaca