Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sdk #19

Merged
merged 10 commits into from
Nov 10, 2020
Merged

Bump sdk #19

merged 10 commits into from
Nov 10, 2020

Conversation

buvinghausen
Copy link
Owner

No description provided.

@buvinghausen buvinghausen requested a review from jnm2 August 26, 2020 21:11
@buvinghausen
Copy link
Owner Author

@jnm2 it appears they pulled .net core 2.1 and 3.1 runtimes from the base image

2020-08-27T21:09:21.6676194Z The framework 'Microsoft.NETCore.App', version '3.1.0' was not found.
2020-08-27T21:09:22.7219602Z The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.

@jnm2
Copy link
Collaborator

jnm2 commented Aug 27, 2020

@buvinghausen Perhaps the installation step caused the SDK to stop finding the installed frameworks.

@jnm2
Copy link
Collaborator

jnm2 commented Aug 28, 2020

The easiest thing might be to add two more installation steps for now. They would be runtime installations instead of SDK installations.

@buvinghausen
Copy link
Owner Author

@jnm2 yeah we only need the runtimes and not additional sdks. Do you know if there is a runtime installing action available off hand?

@jnm2
Copy link
Collaborator

jnm2 commented Aug 28, 2020

@buvinghausen It's usually a parameter of the same action.

@jnm2
Copy link
Collaborator

jnm2 commented Aug 28, 2020

Hmm, doesn't look like this one supports that. Also: actions/setup-dotnet#25

@jnm2
Copy link
Collaborator

jnm2 commented Aug 28, 2020

Maybe we have to https://dot.net/v1/dotnet-install.ps1 directly: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script. It has a --runtime/-Runtime switch that installs just the runtime instead of the whole SDK.

Here's a place where I did that:
https://github.com/nunit/nunit/blob/11ebd486b11e535c774f0de17910d6907a847724/appveyor.yml#L7-L9

@buvinghausen
Copy link
Owner Author

@jnm2 yeah you can see who the last commenter on setup-dotnet 25 is.... ha

I'll see if I have any luck with the install script because it definitely would be nice to be able to include the runtimes for testing and not have to wait on the official image to update or maintain.

@buvinghausen
Copy link
Owner Author

@jnm2 it feels dirty installing 3 SDKs when you need 1 SDK and 2 runtimes but I followed the SxS advice on setup-dotnet #25 and it works so for now I'm just going to leave it in and we can optimize later if the time ever comes.

@buvinghausen buvinghausen merged commit 3cb44de into master Nov 10, 2020
@buvinghausen buvinghausen deleted the bump-sdk branch November 10, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants