Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bug fix code #149

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Remove bug fix code #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions mrblib/rf/buffered_io.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,8 @@ def gets
fill_buffer if @buffer.empty?
break if @buffer.empty?

if @buffer =~ /\n/
# bug: In the case of binary files, String#index enters an infinite loop, thus returning the entire buffer.
# see. https://github.com/mruby/mruby/issues/6143
if @binary
line = @buffer.slice!(0..-1)
@buffer.clear
break
end

newline_index = @buffer.index("\n")
newline_index = @buffer.index("\n")
if newline_index
line << @buffer.slice!(0..newline_index)
break
else
Expand Down