Bug 1492074 - Syntax parse of dynamic module import syntax should fai…

…l since this is not yet implemented r=jandem on a CLOSED TREE
buttercookie42 · Sep 18, 2018 · 10ad45b · 10ad45b
1 parent 3b7081b
commit 10ad45b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/js/src/frontend/Parser.cpp b/js/src/frontend/Parser.cpp
@@ -10597,6 +10597,10 @@ Parser<ParseHandler, CharT>::importExpr(YieldHandling yieldHandling)
 
         MUST_MATCH_TOKEN_MOD(TokenKind::RightParen, TokenStream::Operand, JSMSG_PAREN_AFTER_ARGS);
 
+        if (!abortIfSyntaxParser()) {
+            return null();
+        }
+
         return handler.newCallImport(importHolder, arg);
     } else {
         error(JSMSG_UNEXPECTED_TOKEN_NO_EXPECT, TokenKindToDesc(next));

diff --git a/js/src/jit-test/tests/modules/dynamic-import-lazy.js b/js/src/jit-test/tests/modules/dynamic-import-lazy.js
@@ -0,0 +1,6 @@
+// |jit-test| error: SyntaxError
+
+function lazyilyParsedFunction()
+{
+    return import("/module1.js");
+}