Terminal themes use ANSI colors #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-Barclay
requested changes
Feb 13, 2017
There was a problem hiding this comment.
Looks good!
There is an issue, though, that 7 themes would go missing after this merge: inverse, linux, man-page, novel, red, Christmas, and github. You can see this if you compare lib/termination.coffee.
Did you base this on the latest code from Termination?
Once that's fixed and I've had a chance to test this, I'll definitely merge you in. This is great! 😄
|
Merged, thanks! ae4dee7 |
Fred-Barclay
added a commit
that referenced
this pull request
Apr 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting ANSI colors is a critical part of a theme looking good. Instead of allowing the user to customize the ANSI theme colors, the theme itself should set the colors, as most terminal themes do (besides the osx default themes).
Examples of before and after with this PR:
Solarized Dark
Dracula
One Dark
