Use latest Binject/debug version to support importmap directives #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this by merging in the code from #186 and uncommenting the |
|
So #186 should be merged before this and then rebase? |
|
I think the easiest thing to do is merge this and then change #186 to enable the |
|
I think the other way around is easier because you are currently online, please rebase and enable the test. |
|
Sure, no problem. I'll also enable the added line the to |
capnspacehook
force-pushed
the
fix/importmap
branch
from
bca7dc8 to
28a5265
Compare
|
Forgot to initial test without |
lu4p
approved these changes
Nov 8, 2020
|
Ok feel free to merge yourself, when tests pass. |
… differently in a package that imported it, due to the mapping of import paths. Also commented out the 'net' import in the goprivate testscript (again) due to cgo compile errors
capnspacehook
force-pushed
the
fix/importmap
branch
from
accbe4d to
fe4d998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #146 and #186.