Fix lint and update README.md and CHANGELOG.md

burhanrashid52 · Nov 1, 2020 · 6bff748 · 6bff748
1 parent de64e54
commit 6bff748
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -57,4 +57,8 @@ new TextStyleBuilder()
 ## 1.0.0
 - New : Migrating the support libraries to AndroidX
 - New : Bumped target sdk version to 29
-- Test : Adding UI to test for the library
+- Test : Adding UI to test for the library
+
+## 1.1.0
+- Fixed : #263 and #57
+- New : Allowing `PhotoEditor` to extend with protected constructor.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # PhotoEditor
 
 [![CircleCI](https://circleci.com/gh/burhanrashid52/PhotoEditor.svg?style=svg)](https://circleci.com/gh/burhanrashid52/PhotoEditor)
-[![Downloads](https://img.shields.io/badge/Download-1.0.0-blue.svg)](https://bintray.com/burhanrashid52/maven/photoeditor) ![API](https://img.shields.io/badge/API-14%2B-brightgreen.svg) [![JavaDoc](https://img.shields.io/badge/JavaDoc-PhotoEditor-blue.svg)](https://burhanrashid52.github.io/PhotoEditor/) [![Uplabs](https://img.shields.io/badge/Uplabs-PhotoEditor-orange.svg)](https://www.uplabs.com/posts/photoeditor)
+[![Downloads](https://img.shields.io/badge/Download-1.1.0-blue.svg)](https://bintray.com/burhanrashid52/maven/photoeditor) ![API](https://img.shields.io/badge/API-14%2B-brightgreen.svg) [![JavaDoc](https://img.shields.io/badge/JavaDoc-PhotoEditor-blue.svg)](https://burhanrashid52.github.io/PhotoEditor/) [![Uplabs](https://img.shields.io/badge/Uplabs-PhotoEditor-orange.svg)](https://www.uplabs.com/posts/photoeditor)
 [![AndroidArsenal](https://img.shields.io/badge/Android%20Arsenal-PhotoEditor-blue.svg)](https://android-arsenal.com/details/1/6736)
 [![AndroidDevDigest](https://img.shields.io/badge/AndroidDev%20Digest-%23185-brightgreen.svg)](https://www.androiddevdigest.com/digest-185)
 [![AwesomeAndroid](https://img.shields.io/badge/Awesome%20Android-%2397-red.svg)](https://android.libhunt.com/newsletter/97)
@@ -38,7 +38,7 @@ PhotoEditor ```v.1.0.0``` is a migration to androidX and dropping the support of
 ## Getting Started
 To start with this, we need to simply add the dependencies in the gradle file of our app module like this
 ```java
-implementation 'ja.burhanrashid52:photoeditor:1.0.0'
+implementation 'ja.burhanrashid52:photoeditor:1.1.0'
 ```
 or we can also import the :photoeditor module from sample for further customization
 
@@ -261,6 +261,7 @@ No. Currently, the focus is on making the android library better. We don't have
 
 ### Who is using PhotoEditor?
 1. [Best Quotes & Status 2019 (99000+ Collection)](https://play.google.com/store/apps/details?id=com.swastik.quotesandstatus&hl=en_US)
+2. [Pixxo](https://play.google.com/store/apps/details?id=com.pixxo.breezil.pixxo)
 
 **Note**: I will be happy to add your app to the list. Please reach out to me with details. You know how to reach me :)
 

diff --git a/app/build.gradle b/app/build.gradle
@@ -23,7 +23,7 @@ dependencies {
     implementation 'androidx.appcompat:appcompat:1.2.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
     implementation 'com.google.android.material:material:1.2.1'
-    implementation 'ja.burhanrashid52:photoeditor:1.0.0'
+    implementation 'ja.burhanrashid52:photoeditor:1.1.0'
     //implementation project(':photoeditor')
     implementation 'androidx.cardview:cardview:1.0.0'
 

diff --git a/app/src/main/res/layout/fragment_bottom_properties_dialog.xml b/app/src/main/res/layout/fragment_bottom_properties_dialog.xml
@@ -23,7 +23,8 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@+id/sbOpacity"
         tools:background="@android:color/black"
-        tools:listitem="@layout/color_picker_item_list" />
+        tools:listitem="@layout/color_picker_item_list"
+        android:layout_alignParentRight="true" />
 
     <SeekBar
         android:id="@+id/sbOpacity"

diff --git a/app/src/main/res/layout/fragment_bottom_sticker_emoji_dialog.xml b/app/src/main/res/layout/fragment_bottom_sticker_emoji_dialog.xml
@@ -23,7 +23,8 @@
             android:textAppearance="@style/TextAppearance.AppCompat.Large.Inverse"
             android:visibility="gone"
             app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toTopOf="parent" />
+            app:layout_constraintTop_toTopOf="parent"
+            android:layout_marginLeft="8dp" />
 
         <View
             android:id="@+id/lineView"
@@ -54,7 +55,8 @@
             android:textAppearance="@style/TextAppearance.AppCompat.Large.Inverse"
             android:visibility="gone"
             app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toTopOf="parent" />
+            app:layout_constraintTop_toTopOf="parent"
+            android:layout_marginRight="8dp" />
 
 
     </androidx.constraintlayout.widget.ConstraintLayout>

diff --git a/app/src/main/res/layout/layout_tools_paint.xml b/app/src/main/res/layout/layout_tools_paint.xml
@@ -70,6 +70,7 @@
         android:layout_marginTop="8dp"
         android:padding="4dp"
         android:src="@drawable/ic_eraser"
+        app:layout_constraintTop_toTopOf="@+id/guideline"
         app:layout_constraintEnd_toStartOf="@+id/imgSticker"
         app:layout_constraintHorizontal_bias="0.5"
         app:layout_constraintStart_toEndOf="@+id/imgText" />
@@ -83,6 +84,7 @@
         android:src="@drawable/ic_sticker"
         app:layout_constraintEnd_toStartOf="@+id/imgEmoji"
         app:layout_constraintHorizontal_bias="0.5"
+        app:layout_constraintTop_toTopOf="@+id/guideline"
         app:layout_constraintStart_toEndOf="@+id/btnEraser" />
 
     <ImageView

diff --git a/app/src/main/res/layout/row_editing_tools.xml b/app/src/main/res/layout/row_editing_tools.xml
@@ -15,6 +15,7 @@
         android:layout_height="@dimen/editor_size"
         android:layout_margin="4dp"
         android:layout_marginBottom="8dp"
+        app:layout_constraintTop_toTopOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         tools:src="@drawable/ic_brush" />

diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.3-bin.zip
diff --git a/photoeditor/build.gradle b/photoeditor/build.gradle
@@ -15,7 +15,7 @@ ext {
     siteUrl = 'https://github.com/burhanrashid52/PhotoEditor'
     gitUrl = 'https://github.com/burhanrashid52/PhotoEditor'
 
-    libraryVersion = '1.0.0'
+    libraryVersion = '1.1.0'
 
     developerId = 'burhanrashid52'
     developerName = 'Burhanuddin Rashid'
@@ -33,8 +33,8 @@ android {
     defaultConfig {
         minSdkVersion 14
         targetSdkVersion 30
-        versionCode 1
-        versionName "1.0.0"
+        versionCode 2
+        versionName "1.1.0"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
 
     }
@@ -55,7 +55,9 @@ android {
         options.addStringOption('Xdoclint:none', '-quiet')
         options.addStringOption('encoding', 'UTF-8')
         options.addStringOption('charSet', 'UTF-8')
+        failOnError false
     }
+
 }
 
 dependencies {
@@ -74,5 +76,5 @@ dependencies {
 }
 
 // Place it at the end of the file
-//apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
-//apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle'
+apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
+apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle'