Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PipelineConcurrency option #202

Closed

Conversation

derekperkins
Copy link
Contributor

This adds a pipeline option to the DMap pipeline interface, which should be backwards compatible. It also changes the default from 1 to runtime.NumCPU(), which from the variable naming, appears to have been the original intent.

Fixes #201

@buraksezer buraksezer changed the base branch from master to release/v0.5.0 December 28, 2022 21:43
@buraksezer
Copy link
Owner

Some tests are broken. I'll investigate this problem. See this: https://github.com/buraksezer/olric/actions/runs/3794919996/jobs/6457100150#step:7:1353

@derekperkins
Copy link
Contributor Author

Glad the testing triggered that race condition! Running the tests locally passed for me

@buraksezer buraksezer self-requested a review January 2, 2023 20:53
@buraksezer
Copy link
Owner

Hey, @derekperkins could you please update derekperkins:pipeline-cpus? It doesn't include your latest improvements. https://github.com/buraksezer/olric/tree/release/v0.5.0

@derekperkins
Copy link
Contributor Author

Done

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derekperkins
Copy link
Contributor Author

Closed in favor of #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline concurrency hardcoded to 1
2 participants