Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response id to error messages from failed requests  #88

Closed
OGKevin opened this issue Dec 24, 2017 · 0 comments
Closed

Add response id to error messages from failed requests  #88

OGKevin opened this issue Dec 24, 2017 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
0.12.5

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Dec 24, 2017 •
edited
Loading

Steps to reproduce:

  1. Make a bad request
  2. Try and get the response id from the X-Bunq-Server-Response-Id header.

What should happen:

  1. There is a way to get the response id to debug this error on bunq's side if needed.

What happens:

  1. 👆 is not possible.

Logs

  • Logs 'no logs

Extra info:

References
@OGKevin OGKevin added this to the 0.12.5 milestone Dec 24, 2017
@OGKevin OGKevin self-assigned this Dec 24, 2017
This was referenced Dec 24, 2017
Closed
Closed
Closed
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added response id header constants. (#88)
45be7c9
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added new responseId field to base exception class. (#88)
c52b859
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Altered generateErrorMessage to also include the response id in the e…
f5c817b 
…rror message. (#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Pass the response id to the exceptions in ExceptionFactory. (#88)
8167e46
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added missing spaces for better method formatting. (#88)
cf57be3
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added error constant in case response header retrieval fails. (#88)
78a8091
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added method to get the response id from the failed request response. (…
1a95062 
…#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added test to make sure that the response header can be retrieved fro…
fd7ad63 
…m a failed request. (#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Optimised imports. (#88)
2dcb80c
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added response id header constants. (#88)
1b4c193
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added new responseId field to base exception class. (#88)
9c2b3f0
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Altered generateErrorMessage to also include the response id in the e…
639a10d 
…rror message. (#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Pass the response id to the exceptions in ExceptionFactory. (#88)
d4f0415
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added missing spaces for better method formatting. (#88)
c727a3d
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added error constant in case response header retrieval fails. (#88)
df5e038
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added method to get the response id from the failed request response. (…
1b5ddd9 
…#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added test to make sure that the response header can be retrieved fro…
d1e10bc 
…m a failed request. (#88)
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Optimised imports. (#88)
1a5188b
@OGKevin OGKevin mentioned this issue Dec 26, 2017
Merged
1 task
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Removed plural variables. (#88)
399e4b7
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Changed constant name of GLUE_ERROR_MESSAGES to SEPARATOR_ERROR_MESSA…
842a97f 
…GES. (#88)
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Removed unneeded empty new line. (#88)
91ed2ee
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Extracted magic value. (#88)
bf43b95
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Fixed typo in caughtExcretion to caughtException. (#88)
350bce2
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Removed plural from glueMessages. (#88)
52d4a56
OGKevin added a commit that referenced this issue Dec 27, 2017
@OGKevin
Removed plural parameter from glueAllMessage. (#88)
2ea3657
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Reanmed response header constants to the propper name. (#88)
7b09710
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added response id header constants. (#88)
c77832d
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added new responseId field to base exception class. (#88)
1b3aaa5
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Altered generateErrorMessage to also include the response id in the e…
1bd4279 
…rror message. (#88)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Pass the response id to the exceptions in ExceptionFactory. (#88)
d1ff10b
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added missing spaces for better method formatting. (#88)
872c4a0
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added error constant in case response header retrieval fails. (#88)
e201559
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added method to get the response id from the failed request response. (…
33b8e35 
…#88)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added test to make sure that the response header can be retrieved fro…
1a182a6 
…m a failed request. (#88)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Optimised imports. (#88)
ad04c24
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Removed plural variables. (#88)
c3c5089
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Changed constant name of GLUE_ERROR_MESSAGES to SEPARATOR_ERROR_MESSA…
f7178b7 
…GES. (#88)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Removed unneeded empty new line. (#88)
041550b
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Extracted magic value. (#88)
cd65652
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Fixed typo in caughtExcretion to caughtException. (#88)
f96b6b6
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Removed plural from glueMessages. (#88)
1f8fbf3
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Removed plural parameter from glueAllMessage. (#88)
c9a2379
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Reanmed response header constants to the propper name. (#88)
3653cf3
andrederoos added a commit that referenced this issue Jan 2, 2018
@andrederoos
Merge pull request #93 from bunq/feature/#88-add_response_id_to_reque…
4b645d6 
…st_error

Add response id to request error. (#88)
informeronline pushed a commit to informeronline/bunq_sdk_php that referenced this issue Oct 10, 2023
@andrederoos
Merge branch 'develop' into feature/bunq#88-add_response_id_to_reques…
f040d04 
…t_error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
0.12.5
Development

No branches or pull requests
1 participant
@OGKevin