Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor change in API to enable non-static usage #98

Closed
wants to merge 4 commits into from

Conversation

tubbynl
Copy link
Contributor

@tubbynl tubbynl commented Jun 14, 2018

a smaller change towards #93

this change enables creation of the userContext based on the sessionContext so it can be used outside the static context of BunqContext

the required change is to add the public modifier onto the SessionContext class to expose it's public methods correctly outside the package

@tubbynl tubbynl changed the title Master minor change in API to enable non-static usage Jun 14, 2018
@tubbynl
Copy link
Contributor Author

tubbynl commented Jun 14, 2018

perhaps the merge target should be master?

@OGKevin
Copy link
Contributor

OGKevin commented Jun 14, 2018

Some questions/remarks

  1. why are you working from master branch ?
  2. your manually changing code in generated code, which will be overwritten.
  3. Session context should not be publicly accessible, as the end user should not interact with it. hence its package private.
  4. The migration to none static is long away, i would like to move everything on one go. Son once we are approaching the 2.0.0 release. there is plenty other issues to tackle before that.

@tubbynl
Copy link
Contributor Author

tubbynl commented Jun 14, 2018

  1. will fix the branch
  2. i need two listing methods for accepting a ApiContext to use; i'll create a Class in .code (like SessionServer) to fix that
  3. i don't need Session to be accessible, i only need UserId, and that is currently also exposed via BunqContext.getUserContext().getUserId()
  4. These fixes are meant to be non-breaking steps towards the final goal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants