-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constructor with request field bunq/sdk_java#50 #95
Add constructor with request field bunq/sdk_java#50 #95
Conversation
@patrickdw1991 please 👀 |
@@ -30,6 +31,16 @@ | |||
*/ | |||
private static final int INDEX_FIRST = 0; | |||
|
|||
/** | |||
* String format consents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should say contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants xD :D
private static final String STRING_EMPTY = ""; | ||
|
||
/** | ||
* Regex constatns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants
@@ -179,4 +190,11 @@ protected static Integer determineMonetaryAccountId(Integer id) { | |||
return id; | |||
} | |||
} | |||
|
|||
protected static byte[] determineRequestByte(HashMap<String, Object> requestMap) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just one byte right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough.
@patrickdw1991 pushed |
References #50