Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor with request field bunq/sdk_java#50 #95

Merged
merged 6 commits into from
Jun 7, 2018
Merged

Add constructor with request field bunq/sdk_java#50 #95

merged 6 commits into from
Jun 7, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Jun 5, 2018

References #50

@OGKevin OGKevin added this to the 1.0.0 milestone Jun 5, 2018
@OGKevin OGKevin self-assigned this Jun 5, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 5, 2018

@patrickdw1991 please 👀

patrickdw1991
patrickdw1991 requested changes Jun 7, 2018
View reviewed changes
src/main/java/com/bunq/sdk/model/core/BunqModel.java Outdated
@@ -30,6 +31,16 @@
*/
private static final int INDEX_FIRST = 0;

/**
* String format consents.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should say contents

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants xD :D

src/main/java/com/bunq/sdk/model/core/BunqModel.java Outdated
private static final String STRING_EMPTY = "";

/**
* Regex constatns.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants

src/main/java/com/bunq/sdk/model/core/BunqModel.java Outdated
@@ -179,4 +190,11 @@ protected static Integer determineMonetaryAccountId(Integer id) {
return id;
}
}

protected static byte[] determineRequestByte(HashMap<String, Object> requestMap) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just one byte right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough.

@bunq bunq deleted a comment Jun 7, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 7, 2018

@patrickdw1991 pushed

@OGKevin OGKevin merged commit 53d5a48 into develop Jun 7, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 7, 2018

@andrederoos

@OGKevin OGKevin deleted the add-constructor-with-request-field-bunq/sdk_java#50 branch June 7, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdw1991 patrickdw1991 patrickdw1991 approved these changes

Assignees

@OGKevin OGKevin

Labels
Can be merged
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@OGKevin @patrickdw1991