Regenerate code for release #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickdw1991 please 👀 |
| private static final int NUM_BITS_20_DECIMAL_DIGITS = 66; | ||
| private static final int RADIX_DIGITS_AND_LATIN_LETTERS = 36; | ||
| private static final String CARD_PIN_ASSIGNMENT_TYPE_PRIMARY = "PRIMARY"; |
There was a problem hiding this comment.
Is there a reason why this is not an enum? Or is that impossible to generate?
There was a problem hiding this comment.
Generating ENUMs is also on the list. But its kind of impossible however. Will PM you the details.
patrickdw1991
previously approved these changes
Mar 2, 2018
|
@OGKevin All good :) |
|
@andrederoos please have a look |
andrederoos
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: