Regenerated code to add corerct object types. (bunq/sdk_java#47) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
39tests | 1failures | 0ignored | 38.142sduration |
|
@patrickdw1991 Please 👀 🍿 |
| @@ -31,7 +31,6 @@ | |||
| /** | |||
| * Object type. | |||
| */ | |||
| private static final String OBJECT_TYPE = "AttachmentMonetaryAccount"; | |||
There was a problem hiding this comment.
Is it intended that the comment is still there when there are no constants to which the comment belongs to?
There was a problem hiding this comment.
Ah no, the constant generator is not checking to see if it actually has constants to put underneath the doc block 😅. Nice catch!
There was a problem hiding this comment.
Fixed in generator, pending review.
|
@patrickdw1991 yours again please 👀 |
patrickdw1991
approved these changes
Feb 2, 2018
|
@OGKevin Approved, GOGOGO |
andrederoos
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: