-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated code to add corerct object types. (bunq/sdk_java#47) #70
Conversation
39tests | 1failures | 0ignored | 38.142sduration |
@patrickdw1991 Please 👀 🍿 |
@@ -31,7 +31,6 @@ | |||
/** | |||
* Object type. | |||
*/ | |||
private static final String OBJECT_TYPE = "AttachmentMonetaryAccount"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended that the comment is still there when there are no constants to which the comment belongs to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, the constant generator is not checking to see if it actually has constants to put underneath the doc block 😅. Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in generator, pending review.
@patrickdw1991 yours again please 👀 |
@OGKevin Approved, GOGOGO |
This PR closes/fixes the following issues: