-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bunq/sdk_java#55) add response id to request error #61
(bunq/sdk_java#55) add response id to request error #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some new lines.
import static org.junit.Assert.assertNotNull; | ||
|
||
public class ErrorResponseTest extends BunqSdkTestBase { | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enter
assertNotNull(caughtException); | ||
assertNotNull(caughtException.getResponseId()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No plural names. 💅
} | ||
} | ||
|
||
private static String concatenateMessages(List<String> messages) { | ||
return String.join(GLUE_ERROR_MESSAGES, messages); | ||
private static String concatenateMessages(List<String> messages, String responseId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plural 🙅♂️
@patrickdw1991 all yours please 👀 |
21ef1eb
to
7bbc4c6
Compare
@andrederoos all yours please 👀 |
String responseBody) { | ||
List<String> errorDescriptions = new ArrayList<>(); | ||
String responseBody, String responseId) { | ||
List<String> AllErrorDescription = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the capital?
return headerMap.get(HEADER_RESPONSE_ID_LOWER_CASE); | ||
} else if (headerMap.containsKey(HEADER_RESPONSE_ID_UPPER_CASE)) { | ||
return headerMap.get(HEADER_RESPONSE_ID_UPPER_CASE); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the else...
d5b6270
to
1d00e46
Compare
Closes #55