Added method to ensure that reponse headers are correclty cased befor… #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e verification. (#43)
OGKevin
commented
Dec 21, 2017
| import org.apache.http.Header; | ||
| import org.apache.http.HttpEntityEnclosingRequest; | ||
| import org.apache.http.HttpResponse; | ||
| import org.apache.http.client.methods.*; |
patrickdw1991
requested changes
Dec 21, 2017
| /** | ||
| * Substring constants. | ||
| */ | ||
| private static final int SUBSTRING_BEGIN_INDEX = 0; |
There was a problem hiding this comment.
Constants can have better names, have no clue what this is about. If we would add a second substring with different params it would be really confusing.
| @@ -486,6 +521,21 @@ public static void validateResponseSignature(int responseCode, byte[] responseBo | |||
| return outputStream.toByteArray(); | |||
| } | |||
|
|
|||
| private static String ensureHeaderCorrectlyCased(String headerName) { | |||
There was a problem hiding this comment.
ernsure sounds like we're asserting, while this would return a value.
patrickdw1991
approved these changes
Dec 21, 2017
andrederoos
deleted the
feature/make_sure_headers_are_correctly_cased_bunq/sdk_java#43
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43