Feature/improve decoder bunq/sdk java#35 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
commented
Dec 20, 2017
|
|
||
|
|
||
| if (model.isAllFieldNull()) { | ||
|
|
| for(Field field : allFields) { | ||
|
|
||
| if (!BunqModel.class.isAssignableFrom(field.getType())) { | ||
|
|
OGKevin
commented
Dec 20, 2017
| Field[] allFields = model.getClass().getDeclaredFields(); | ||
|
|
||
| for(Field field : allFields) { | ||
|
|
There was a problem hiding this comment.
This line can also go as well
patrickdw1991
requested changes
Dec 20, 2017
| import com.bunq.sdk.exception.BunqException; | ||
| import com.bunq.sdk.model.core.AnchorObjectInterface; | ||
| import com.bunq.sdk.model.core.BunqModel; | ||
| import com.google.gson.*; |
|
|
||
| public class AnchorObjectAdapter implements JsonDeserializer<AnchorObjectInterface> { | ||
| @Override | ||
| public AnchorObjectInterface deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws |
There was a problem hiding this comment.
Moving throws to next line makes it nicer readable
| public AnchorObjectInterface deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws | ||
| JsonParseException { | ||
| AnchorObjectInterface model = new Gson().fromJson(json, typeOfT); | ||
|
|
| } catch (IllegalAccessException e) { | ||
| throw new BunqException(e.getMessage()); | ||
| } | ||
| field.setAccessible(false); |
| @@ -34,6 +35,13 @@ | |||
| protected BunqModel() { | |||
| } | |||
|
|
|||
| public static <T> T fromJsonReader(Class<T> tClass, JsonReader reader) { | |||
|
@patrickdw1991 All yours please 👀 |
patrickdw1991
approved these changes
Dec 21, 2017
|
@andrederoos All yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Closes #35