extracted header-magic as enum (bunq/sdk_java#93) #102

tubbynl · 2018-06-17T18:11:23Z

i extracted magic constants into BunqHeader enum, added some junit tests on it

behaviour is as-is, but tests are not really runnable locally

i'm using the bunq api currently in a spring-boot setup using rest-template, most of the gson/models i can use for deserializing the responses and in order to mimic the header handling i needed to copy some of the header names into my project.

i extracted that into an BunqHeader enum which you see here, if this get's into the sdk_java project i can remove this from my project :)

BunqHeader, and added some junit tests on it

OGKevin · 2018-06-17T18:44:41Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

+  private final BunqHeader name;
+  private final String value;
+
+  public static BunqBasicHeader get(BunqHeader header,Response response) {


missing space after ,.

OGKevin · 2018-06-17T18:45:55Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

+  private final BunqHeader name;
+  private final String value;
+
+  public static BunqBasicHeader get(BunqHeader header,Response response) {


This is not really a getter but rather a create method, so please rename this method to create

OGKevin · 2018-06-17T18:46:09Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

+  private final String value;
+
+  public static BunqBasicHeader get(BunqHeader header,Response response) {
+    return new BunqBasicHeader(header,response.header(header.getHeader()));


missing space after ,

OGKevin · 2018-06-17T18:47:04Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java


-  /**
-   */
  public BunqBasicHeader(String name, String value) {


is there a reason why the constructor is still pubic while you have introduced a create method. Either make the constructor private/protected or remove the create method.

OGKevin · 2018-06-17T18:47:12Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

+    this(BunqHeader.parse(name).get(),value);
+  }
+
+  public BunqBasicHeader(BunqHeader name, String value) {


same as above.

OGKevin · 2018-06-17T19:17:59Z

src/test/java/com/bunq/sdk/http/BunqHeaderTest.java

+        assertEquals("0 0 0 0 000",headers.get("X-Bunq-Geolocation"));
+        assertEquals("test-agent",headers.get("User-Agent"));
+    }
+}


missing new line at EOF

i changed this in BunqHeaderTest, see ad67ada

OGKevin · 2018-06-17T19:19:00Z

src/test/java/com/bunq/sdk/model/generated/endpoint/AvatarTest.java

@@ -54,10 +55,8 @@ public void createAvatarTest() {

  private String uploadAvatar(byte[] file_contents) {
    HashMap<String, String> customHeaders = new HashMap<>();


I know you didn't wrote this line, but please refactor to allCustomHeader

OGKevin · 2018-06-17T19:19:05Z

src/test/java/com/bunq/sdk/model/generated/endpoint/AvatarTest.java

-    customHeaders.put(ApiClient.HEADER_ATTACHMENT_DESCRIPTION, ATTACHMENT_PATH_IN);
-    customHeaders.put(ApiClient.HEADER_CONTENT_TYPE, CONTENT_TYPE);
-
+    BunqHeader.attachmentDescription.addTo(customHeaders,ATTACHMENT_PATH_IN);


missing space

OGKevin · 2018-06-17T19:19:11Z

src/test/java/com/bunq/sdk/model/generated/endpoint/AvatarTest.java

-    customHeaders.put(ApiClient.HEADER_CONTENT_TYPE, CONTENT_TYPE);
-
+    BunqHeader.attachmentDescription.addTo(customHeaders,ATTACHMENT_PATH_IN);
+    BunqHeader.contentType.addTo(customHeaders,CONTENT_TYPE);


missing space

OGKevin · 2018-06-17T19:19:24Z

src/test/java/com/bunq/sdk/model/generated/endpoint/AvatarTest.java

    return AttachmentPublic.create(customHeaders, file_contents).getValue();
  }
-


please revert the removal of this line.

tubbynl · 2018-06-17T19:25:25Z

i've processed the formatting thingies :)

tubbynl · 2018-06-17T19:28:50Z

i can't really see what's up with

com.bunq.sdk.model.generated.endpoint.CardDebitTest > orderNewMaestroCardTest FAILED
com.bunq.sdk.exception.BadRequestException at CardDebitTest.java:80

but i think the formatting-relevant-header stuff is functional now; i intent to add some more tests with relevant request/response header content to validate that

OGKevin · 2018-06-17T19:32:37Z

@tubbynl there are still some comments open.

It seems that your commit messages are still not passing. Your missing .(periods). But i will change the regex to approve commits without periods.

OGKevin

There are still a few unresolved old comments

OGKevin · 2018-06-19T07:01:37Z

src/main/java/com/bunq/sdk/http/ApiClient.java

@@ -320,10 +285,7 @@ private BunqResponseRaw createBunqResponseRaw(Response response)
   */
  private static String getResponseId(Response response) {
    Map<String, String> headerMap = getHeadersMap(response);
-


This new line should come back

OGKevin · 2018-06-19T07:03:21Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

 public class BunqBasicHeader {
-  private String name;
-  private String value;
+  private static final String DELIMITER_HEADER_NAME_AND_VALUE = ": ";


Missing constant group doc block.

In this case it can be

/** * String format constants. */

and perpend these 2 constants with FORMAT_

OGKevin · 2018-06-19T07:03:47Z

src/main/java/com/bunq/sdk/http/BunqBasicHeader.java

-   */
-  public BunqBasicHeader(String name, String value) {
+  public static Optional<BunqBasicHeader> get(String header, String value) {
+    return BunqHeader.parse(header).map(h -> new BunqBasicHeader(h,value));


This is not java 7 compatible. Please refactor this so that it is.

And please add missing space after ,

tubbynl added 2 commits June 17, 2018 20:04

extracted header-magic as enum (bunq#93)

6486716

BunqHeader, and added some junit tests on it

fix test on header signing (bunq#93)

ffb56ad

tubbynl force-pushed the develop-93-headers-enum branch from dece499 to ffb56ad Compare June 17, 2018 19:14

OGKevin suggested changes Jun 17, 2018

View reviewed changes

formatting feedback (bunq#93)

ad67ada

OGKevin suggested changes Jun 19, 2018

View reviewed changes

tubbynl added 2 commits June 19, 2018 09:31

formatting feedback, java7 (bunq#93)

4cd229c

formatting feedback, java7 (bunq#93)

6b90696

bunq deleted a comment Jun 19, 2018

formatting feedback (bunq#93)

0ebd723

tubbynl force-pushed the develop-93-headers-enum branch from 0bca993 to 0ebd723 Compare June 19, 2018 18:03

bunq deleted a comment Jun 19, 2018

tubbynl closed this Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extracted header-magic as enum (bunq/sdk_java#93) #102

extracted header-magic as enum (bunq/sdk_java#93) #102

tubbynl commented Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

tubbynl Jun 17, 2018

OGKevin Jun 17, 2018

tubbynl Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

OGKevin Jun 17, 2018

tubbynl commented Jun 17, 2018

tubbynl commented Jun 17, 2018

OGKevin commented Jun 17, 2018

OGKevin left a comment

OGKevin Jun 19, 2018

OGKevin Jun 19, 2018

OGKevin Jun 19, 2018

		@@ -54,10 +55,8 @@ public void createAvatarTest() {

		private String uploadAvatar(byte[] file_contents) {
		HashMap<String, String> customHeaders = new HashMap<>();

		return AttachmentPublic.create(customHeaders, file_contents).getValue();
		}

extracted header-magic as enum (bunq/sdk_java#93) #102

extracted header-magic as enum (bunq/sdk_java#93) #102

Conversation

tubbynl commented Jun 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tubbynl commented Jun 17, 2018

tubbynl commented Jun 17, 2018

OGKevin commented Jun 17, 2018

OGKevin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment