Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response is missing response headers and pagination #4

Closed
dnl-blkv opened this issue Aug 9, 2017 · 5 comments
Closed

Response is missing response headers and pagination #4

dnl-blkv opened this issue Aug 9, 2017 · 5 comments
Assignees
@dnl-blkv
Labels
enhancement
Milestone
v0.11.0

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 9, 2017

How to Reproduce

  1. Make a valid listing request to bunq API via the Java SDK
  2. Make a valid get/put/post/delete request to bunq API via the Java SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
@dnl-blkv dnl-blkv self-assigned this Aug 9, 2017
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 switch to BunqResponse
698df52
@OGKevin OGKevin added this to the v0.10.0 milestone Aug 9, 2017
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 fix tests to work with BunqResponse
678cbba
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 generate missing models, objects and methods
58088f8
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 resurrect response validation
f8f503a
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 remove junk lines
e7e1aa0
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#4 fix location of BunqResponse
626826a
andrederoos added a commit that referenced this issue Aug 14, 2017
@andrederoos
Merge pull request #5 from bunq/4-bunq-response
3207d2c 
#4 Introduce BunqResponse
@OGKevin
Copy link
Contributor

OGKevin commented Aug 23, 2017

Closing I favour of #5

@OGKevin OGKevin closed this as completed Aug 23, 2017
@dnl-blkv
Copy link
Contributor Author

@OGKevin but pagination is sill not in!

@dnl-blkv dnl-blkv reopened this Aug 23, 2017
@OGKevin
Copy link
Contributor

OGKevin commented Aug 23, 2017

Ah, i was closing all the issue in the milestone 😊.

0.11.0 ?

@dnl-blkv
Copy link
Contributor Author

Yes please! :)

@OGKevin OGKevin modified the milestones: v0.11.0, v0.10.0 Aug 24, 2017
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
Add pagination; cleanup; add missing endpoitns and fields [#4]
73d2985
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
reformat [#4]
2633440
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
update example; cleanup [#4]
6b326f3
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
Fix Pagination deserialization and payment list example [#4]
4a8346f
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
remove extra import [#4]
6e9fe73
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
remove extra this [#4]
649f070
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
add missing docs [#4]
c6812a6
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
Fix payment list example [#4]
eb70290
dnl-blkv added a commit that referenced this issue Sep 3, 2017
@dnl-blkv
fix var name [#4]
b0ecd02
dnl-blkv added a commit that referenced this issue Sep 4, 2017
@dnl-blkv
cleanup [#4]
c6eb166
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
Add pagination test; cleanup pagination [#4]
c591bb5
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
clean up tests [#4]
b0d5307
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
Add pagiantion scenario test [#4]
de6fff9
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
restore misc [#4]
59dbf42
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix links to examples [#4]
0fffdd1
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix class name [#4]
7c4b1ee
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix constant names [#4]
67398bb
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix constant names [#4]
1fe261f
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix constant name [#4]
b7b8f51
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix payment description [#4]
8e57608
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
add missing endepoints [#4]
5ee37cf
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
Allow for no IP in config for tests [#4]
a0db646
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
use ArrayList for pagination scenario test [#4]
bf3b4eb
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix delimiter of permitted IPs and example properties [#4]
d143a01
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
remove extra dependencies [#4]
89359e1
dnl-blkv added a commit that referenced this issue Sep 5, 2017
@dnl-blkv
fix variable names [#4]
474dde8
dnl-blkv added a commit that referenced this issue Sep 6, 2017
@dnl-blkv
fix constant names [#4]
129d3aa
dnl-blkv added a commit that referenced this issue Sep 6, 2017
@dnl-blkv
Add missing assertion [#4]
5d2dac1
andrederoos added a commit that referenced this issue Sep 6, 2017
@andrederoos
Merge pull request #13 from bunq/4-pagination
1740c8b 
Add pagination; cleanup; add missing endpoints and fields [#4]
@OGKevin
Copy link
Contributor

OGKevin commented Sep 9, 2017

Closing in favour of #13

@OGKevin OGKevin closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
enhancement
Projects
None yet
Milestone
v0.11.0
Development

No branches or pull requests
2 participants
@dnl-blkv @OGKevin