Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean dependencies #25

Closed
patrickdw1991 opened this issue Oct 16, 2017 · 2 comments · Fixed by #73
Closed

Clean dependencies #25

patrickdw1991 opened this issue Oct 16, 2017 · 2 comments · Fixed by #73
Assignees
@OGKevin
Labels
android specific
Milestone
0.12.5

Comments

@patrickdw1991
Copy link

Currently the bunq java sdk uses dependencies like:

Guava: Really big lib which is only used for nullability annotations.
Alternative for nullability annotations: https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305

Commons-io: Currently using a really out-dated commons-io.
Alternative use newer: https://mvnrepository.com/artifact/commons-io/commons-io

Appache httpclient: Just doesn't really work well with android
Alternative: Okhttp
@OGKevin
Copy link
Contributor

OGKevin commented Oct 16, 2017

Hey @patrickdw1991,

Thanks for these suggestions, will take a look and see if we can use these indeed 👍

@OGKevin OGKevin mentioned this issue Nov 25, 2017
Closed
@OGKevin
Copy link
Contributor

OGKevin commented Nov 28, 2017 •
edited
Loading

Guava will be removed in 0.12.4

@OGKevin OGKevin added this to the 0.12.5 milestone Nov 28, 2017
@OGKevin OGKevin mentioned this issue Jan 18, 2018
Closed
1 task
@OGKevin OGKevin closed this as completed Jan 18, 2018
@OGKevin OGKevin reopened this Jan 19, 2018
This was referenced Jan 27, 2018
Closed
Open
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Replaced httpclient with Okhttp. (#25)
00cc743
@OGKevin OGKevin mentioned this issue Feb 2, 2018
Merged
1 task
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Added 30 seconds time out to requests. (#25)
2d0d89f
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Removed all unused imports and reformatted code. (#25)
362ad29
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Addressed styling issues and general code clean up. (#25)
3bd78cf
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Fixed some styling issues. (#25)
78261b2
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Fixed some styling issues. (#25)
e3442ce
OGKevin added a commit that referenced this issue Feb 2, 2018
@OGKevin
Fixed some styling issues. (#25)
fb26ecb
OGKevin added a commit that referenced this issue Feb 4, 2018
@OGKevin
Fixed method formatting. (#25)
1dcdc43
OGKevin added a commit that referenced this issue Feb 4, 2018
@OGKevin
Added missing doc blocks on methods. (#25)
01577e0
OGKevin added a commit that referenced this issue Feb 4, 2018
@OGKevin
Fixed broken tests. (#25)
2235a4a
OGKevin added a commit that referenced this issue Feb 5, 2018
@OGKevin
Added case to catch a null response code. (#25)
0393ba5
andrederoos added a commit that referenced this issue Feb 15, 2018
@andrederoos
Merge branch 'develop' into #25-use-okhttp
41651e8
OGKevin added a commit that referenced this issue Feb 15, 2018
@OGKevin
Missed a doc block. 🙈. (#25)
ddd991a
OGKevin added a commit that referenced this issue Feb 15, 2018
@OGKevin
Missed a doc block. (#25)
609b35e
OGKevin added a commit that referenced this issue Feb 15, 2018
@OGKevin
Merge pull request #73 from bunq/#25-use-okhttp
a64caab 
Replaced httpclient with Okhttp. (#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
android specific
Projects
None yet
Milestone
0.12.5
Development

Successfully merging a pull request may close this issue.

Replaced httpclient with Okhttp. (bunq/sdk_java#25) bunq/sdk_java
3 participants
@patrickdw1991 @dnl-blkv @OGKevin