Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OauthAuthorizationUri creates incorrect URL #126

Closed
Nayels opened this issue Apr 14, 2020 · 1 comment · Fixed by #133
Closed

OauthAuthorizationUri creates incorrect URL #126

Nayels opened this issue Apr 14, 2020 · 1 comment · Fixed by #133
Assignees
Labels
Milestone

Comments

@Nayels
Copy link

Nayels commented Apr 14, 2020

Steps to reproduce:

  1. Create OauthAuthorizationUri with state

What should happen:

https://oauth.bunq.com/auth?response_type=code&redirect_uri=redirecturi&client_id=client_id&state=state

What happens:

No & that divides the client_id and state parameters resulting in incorrect hash for clientId.

The URL should be:
https://oauth.bunq.com/auth?response_type=code&redirect_uri=redirecturi&client_id=client_idstate=state

SDK version and environment

@angelomelonas
Copy link
Contributor

Hi @Nayels,

Thanks for raising this issue! 🙏🏼 I see we already have a pending PR for it. This will be fixed in the upcoming release (1.14.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment