Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate pinning issue after bunq certificate renewal #123

Closed
1 of 2 tasks
masoudparvari opened this issue Mar 23, 2020 · 6 comments
Closed
1 of 2 tasks

Certificate pinning issue after bunq certificate renewal #123

masoudparvari opened this issue Mar 23, 2020 · 6 comments

Comments

@masoudparvari
Copy link

masoudparvari commented Mar 23, 2020

Steps to reproduce:

  1. Create a BunqContext with the Java SDK

What should happen:

  1. Session should be successfully created and payments should succeed

What happens:

  1. Creation fails with com.bunq.sdk.exception.UncaughtExceptionError: Uncaught exception "Certificate pinning failure!"

SDK version and environment

  • Tested on 1.13.0
  • Sandbox
  • Production

Extra info:

Apparently your old certificate has expired in Wednesday, 21 April 2021 at 14:00:00. And that's hard coded in code.

@saket88
Copy link

saket88 commented Mar 26, 2020

Any details about the fix of this issue?

@DrOof
Copy link

DrOof commented Mar 26, 2020

Is the problem just the pinned key?

SANDBOX(
      "public-api.sandbox.bunq.com",
      "v1",
      "sha256/9Y+oZve6H+r17Kdn+lN5sT0ijgxLyDGIuQtUwLupawA="
  );

@masoudparvari
Copy link
Author

masoudparvari commented Mar 26, 2020

Is the problem just the pinned key?

SANDBOX(
      "public-api.sandbox.bunq.com",
      "v1",
      "sha256/9Y+oZve6H+r17Kdn+lN5sT0ijgxLyDGIuQtUwLupawA="
  );

yes, this should be new key:
sha256/SEJfjAW74vHQmGe/lb9NwBjzAw5y7rpJH3UWpGE5q8A=

@DrOof
Copy link

DrOof commented Mar 26, 2020 via email

@DrOof
Copy link

DrOof commented Mar 27, 2020

I have a patch for ourselves. But I can't push a branch and do a pull request.

DrOof pushed a commit to weird-io/sdk_java that referenced this issue Mar 27, 2020
@FNG21
Copy link
Contributor

FNG21 commented Mar 27, 2020

Hi guys! Thanks for bringing this up :)

To enable you to keep using our SDKs, a PR has been submitted just now that will update the certificate hash. I'll close this issue when the PR is merged so you know when you can continue building great applications with our amazing API!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants