Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to save context to streams #95

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pjvds
Copy link

@pjvds pjvds commented May 25, 2018

This adds the ability to save an api context to a stream, rather than a file. This makes the save more flexible and removes the dependency to the file system for saving and loading contexts.

The pull requests comes with extra unit tests ✅

This adds the ability to save an api context to a stream, rather than a files.
@OGKevin
Copy link
Contributor

OGKevin commented May 25, 2018

@pjvds thanks for this PR, did you read https://raw.githubusercontent.com/bunq/sdk_csharp/develop/.github/PULL_REQUEST_TEMPLATE.md ?

Could you please explain this change in an issue and rebase your commits to link to this issue. Your commit message should pass the following regex:

- '([A-Za-z0-9 ]+)\. (\(bunq\/sdk_csharp#[0-9]+\))'

@bunq bunq deleted a comment May 25, 2018
@bunq bunq deleted a comment May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants