Fixed application lifecycle bunq/doc#75 #78
Conversation
| @@ -67,7 +67,7 @@ class SidebarItem extends React.Component { | |||
|
|
|||
| /** | |||
| */ | |||
| componentDidMount () { | |||
| componentDidUpdate () { | |||
| if (!this.state.isApiEndpoint) { | |||
There was a problem hiding this comment.
in case of componentDidUpdate you want to make a comparison to the previous state. this method runs on every update on anything on state / props, and whenever !this.state.isApiEndpoint holds that code block will be called causing unnecessary rerenders - not sure whether this one would cause an infinite rerender or sth but I would check the behaviour with some logs.
the function signature is componentDidUpdate(prevProps, prevState), this should work nicely if you do if (prevState.isApiEndpoint && !this.state.isApiEndpoint) {
There was a problem hiding this comment.
@melikesofta the state of the component is never updated, so there's no risk of generating an infinite loop. The reason why I want to go this way is that right now I cannot know exactly when the markdown generating the documentation has been displayed, so I want to check this every time I render. Am I missing anything?
There was a problem hiding this comment.
if the result of this.props.bunqSelectors.initializeScrollToTopic(this.state.tag); doesn't affect this component i.e. props sent from the parent will remain the same it should be fine, otherwise it will infinitely trigger a rerender by itself. there might be some props sent down that might not be obvious but still trigger a rerender, but if you already checked or if you are sure it's fine :)
No description provided.