Remove references to PHP examples #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basst85 thanks for this, however i see that this repo is quite.. empty and missing the contribution guidelines 😅. Do you mind rebasing your commit and follow these little steps. This way we can have proper issue/commit tracking. https://raw.githubusercontent.com/bunq/sdk_php/develop/.github/PULL_REQUEST_TEMPLATE.md |
OGKevin
suggested changes
Jun 14, 2018
DESCRIPTION.md
Outdated
| @@ -559,7 +559,7 @@ The calls you need to perform to set up a session from scratch are the following | |||
|
|
|||
| Each call needs to be signed with your own private key. An Installation is used to tell the server about the public key of your key pair. The server uses this key to verify your subsequent calls. | |||
|
|
|||
| Start by generating a 2048-bit RSA key pair. You can find out how to generate a key pair in our PHP coding examples. | |||
| Start by generating a 2048-bit RSA key pair. | |||
There was a problem hiding this comment.
Instead of php coding examples, we can put something along the lines of you can find examples by looking at the source code of the sdk's located at github..
This PHP examples are no longer present on doc,bunq.com, and are also outdated.
OGKevin
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PHP examples are no longer present on doc,bunq.com, and are also outdated.