Add info on encrypting requests and disabling signature validation in sandbox to DESCRIPTION.md #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexym
changed the title
FNG21
reviewed
Dec 20, 2019
DESCRIPTION.md
Outdated
| @@ -500,6 +500,30 @@ If you get an error telling you "The request signature is invalid", please check | |||
| - You use the data to sign to create a SHA256 hash signature. | |||
| - You have base64 encoded the SHA256 hash signature before adding it to the request under `X-Bunq-Client-Signature`. | |||
|
|
|||
| **Note:** Though request signing is a must on production, you can choose to disable it on sandbox to simplify the testing. Here's how it works: | |||
|
|
|||
| 1. Set the `X-Bunq-Client-Signature-Validation-Policy` header of the request to `IGNORE_ONLY_FOR_TESTING`. | |||
There was a problem hiding this comment.
This is now X-Bunq-Client-Signature :)
FNG21
reviewed
Dec 20, 2019
DESCRIPTION.md
Outdated
|
|
||
| Here is how to encrypt a request: | ||
| 1. Generate a random [Initialization Vector](https://en.wikipedia.org/wiki/Initialization_vector) (IV) of 16 bytes. | ||
| 1. Generate a random [Advanced Encryption Standard](https://en.wikipedia.org/wiki/Advanced_Encryption_Standard) (AES) key of 32 bytes. |
There was a problem hiding this comment.
This is my bad, since I told you wrong, but lets make it 256 bits (32 bytes) since in terms of encryption we should always talk in bits. (it is practically the same since 32bytes == 256bits, but makes more sense like this)
(Thats what AES-256-CBC a few lines down comes from) :)
FNG21
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.