Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response id header. #34

Closed
OGKevin opened this issue May 28, 2018 · 1 comment
Closed

Fix response id header. #34

OGKevin opened this issue May 28, 2018 · 1 comment
Assignees
@OGKevin
Labels
Requires: change in base Requires: change in generated
Milestone
0.5.3

Comments

@OGKevin
Copy link
Contributor

OGKevin commented May 28, 2018

Steps to reproduce:

1.Check the response headers of.

What should happen:

  1. There should be X-Bunq-Client-Response-Id

What happens:

  1. Instead there is X-Bunq-Server-Response-Id
@OGKevin OGKevin self-assigned this May 28, 2018
@OGKevin OGKevin added this to the 0.5.1 milestone May 28, 2018
OGKevin added a commit that referenced this issue May 28, 2018
@OGKevin
Renamed response id accordingly. (#34)
7689420
@OGKevin OGKevin mentioned this issue May 28, 2018
Merged
OGKevin added a commit that referenced this issue May 28, 2018
@OGKevin
Merge pull request #35 from bunq/fix-response-id-header-bunq/doc#34
a6bfddf 
Renamed response id accordingly in base json. (#34)
@OGKevin OGKevin closed this as completed May 28, 2018
@OGKevin OGKevin reopened this May 29, 2018
OGKevin added a commit that referenced this issue May 29, 2018
@OGKevin
Regenerated swagger json files. (#34)
307a3e5
OGKevin added a commit that referenced this issue May 29, 2018
@OGKevin
Regenerated doc html. (#34)
1ec3d47
@OGKevin OGKevin mentioned this issue May 29, 2018
Merged
OGKevin added a commit that referenced this issue May 29, 2018
@OGKevin
Merge pull request #37 from bunq/regenerate-response-id-bunq/doc#34
994a338 
Regenerate response id #34
@OGKevin OGKevin closed this as completed May 29, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 1, 2018 •
edited
Loading

Its still there in the description https://doc.bunq.com/#section/Response-Headers

@OGKevin OGKevin reopened this Jun 1, 2018
@OGKevin OGKevin modified the milestones: 0.5.1, 0.5 Jun 1, 2018
OGKevin added a commit that referenced this issue Jun 1, 2018
@OGKevin
Fixed response header name in description. (#34)
b2a9e3b
OGKevin added a commit that referenced this issue Jun 1, 2018
@OGKevin
Regenerated swagger jsons. (#34)
77d75c0
OGKevin added a commit that referenced this issue Jun 1, 2018
@OGKevin
Regenerated doc html. (#34)
ce4ed0e
@OGKevin OGKevin mentioned this issue Jun 1, 2018
Merged
OGKevin added a commit that referenced this issue Jun 1, 2018
@OGKevin
Merge pull request #43 from bunq/fix-response-id-header-bunq/doc#34
1c4ac9f 
Fix response id header #34
@OGKevin OGKevin closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
Requires: change in base Requires: change in generated
Projects
None yet
Milestone
0.5.3
Development

No branches or pull requests
1 participant
@OGKevin