Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSHM useless call to setmetadata when pool is specified #171

Closed
oldium opened this issue Aug 7, 2023 · 1 comment · Fixed by #172
Closed

DSHM useless call to setmetadata when pool is specified #171

oldium opened this issue Aug 7, 2023 · 1 comment · Fixed by #172

Comments

@oldium
Copy link

oldium commented Aug 7, 2023

DSHM constructor calls setmetadata when pool value is specified but ignores the result.

See

if pool or pool_size or backlog then
setmetatable({
prefix = prefix,
suffix = suffix,
host = host,
port = port,
connect_timeout = connect_timeout,
send_timeout = send_timeout,
read_timeout = read_timeout,
keepalive_timeout = keepalive_timeout,
ssl = ssl,
ssl_verify = ssl_verify,
server_name = server_name,
options = {
pool = pool,
pool_size = pool_size,
backlog = backlog,
}
}, metatable)
end
return setmetatable({
prefix = prefix,
suffix = suffix,
host = host,
port = port,
connect_timeout = connect_timeout,
send_timeout = send_timeout,
read_timeout = read_timeout,
keepalive_timeout = keepalive_timeout,
ssl = ssl,
ssl_verify = ssl_verify,
server_name = server_name,
}, metatable)
end

@bungle
Copy link
Owner

bungle commented Aug 15, 2023

good catch! thanks!

bungle added a commit that referenced this issue Aug 16, 2023
… parameters are not respected

### Summary

@oldium resported this issue in #171.
bungle added a commit that referenced this issue Aug 16, 2023
… parameters are not respected

### Summary

@oldium resported this issue in #171.
bungle added a commit that referenced this issue Aug 16, 2023
… parameters are not respected

### Summary

@oldium resported this issue in #171.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants