Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Education and Titles #29

Closed
bundabrg opened this issue Dec 14, 2020 · 2 comments
Closed

Education and Titles #29

bundabrg opened this issue Dec 14, 2020 · 2 comments

Comments

@bundabrg
Copy link
Owner 

com.nukkitx.protocol.bedrock.exception.PacketSerializeException: Error whilst serializing SetTitlePacket(type=TIMES, text=null, fadeInTime=0, stayTime=50, fadeOutTime=30)
        at com.nukkitx.protocol.bedrock.BedrockPacketCodec.tryEncode(BedrockPacketCodec.java:82) ~[Geyser-v1.16-b47.jar:?]
        at au.com.grieve.geyser.reversion.server.GeyserServerSession.sendPacket(GeyserServerSession.java:75) ~[?:?]
        at org.geysermc.connector.network.session.UpstreamSession.sendPacket(UpstreamSession.java:45) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.session.GeyserSession.lambda$sendUpstreamPacket$4(GeyserSession.java:827) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.event.EventResult.onNotCancelled(EventResult.java:59) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.session.GeyserSession.sendUpstreamPacket(GeyserSession.java:825) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.translators.java.JavaTitleTranslator.translate(JavaTitleTranslator.java:77) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.translators.java.JavaTitleTranslator.translate(JavaTitleTranslator.java:36) ~[Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.translators.PacketTranslatorRegistry.translate(PacketTranslatorRegistry.java:100) [Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.session.GeyserSession.handleDownstreamPacket(GeyserSession.java:603) [Geyser-v1.16-b47.jar:?]
        at org.geysermc.connector.network.session.GeyserSession$1.packetReceived(GeyserSession.java:551) [Geyser-v1.16-b47.jar:?]
        at com.github.steveice10.packetlib.event.session.PacketReceivedEvent.call(PacketReceivedEvent.java:51) [Geyser-v1.16-b47.jar:?]
        at com.github.steveice10.packetlib.tcp.TcpSession.callEvent(TcpSession.java:149) [Geyser-v1.16-b47.jar:?]
        at com.github.steveice10.packetlib.tcp.TcpSession$3.run(TcpSession.java:324) [Geyser-v1.16-b47.jar:?]
        at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.NullPointerException: string
        at com.nukkitx.network.util.Preconditions.checkNotNull(Preconditions.java:880) ~[Geyser-v1.16-b47.jar:?]
        at com.nukkitx.protocol.bedrock.BedrockPacketHelper.writeString(BedrockPacketHelper.java:274) ~[Geyser-v1.16-b47.jar:?]
        at com.nukkitx.protocol.bedrock.v291.serializer.SetTitleSerializer_v291.serialize(SetTitleSerializer_v291.java:19) ~[Geyser-v1.16-b47.jar:?]
        at com.nukkitx.protocol.bedrock.v291.serializer.SetTitleSerializer_v291.serialize(SetTitleSerializer_v291.java:11) ~[Geyser-v1.16-b47.jar:?]
        at com.nukkitx.protocol.bedrock.BedrockPacketSerializer.serialize(BedrockPacketSerializer.java:13) ~[Geyser-v1.16-b47.jar:?]
        at com.nukkitx.protocol.bedrock.BedrockPacketCodec.tryEncode(BedrockPacketCodec.java:80) ~[Geyser-v1.16-b47.jar:?]
        ... 14 more
> com.nukkitx.protocol.bedrock.exception.PacketSerializeException: Error whilst serializing SetTitlePacket(type=TIMES, text=null, fadeInTime=0, stayTime=50, fadeOutTime=30)
        at com.nukkitx.protocol.bedrock.BedrockPacketCodec.tryEncode(BedrockPacketCodec.java:82)
        at au.com.grieve.geyser.reversion.server.GeyserServerSession.sendPacket(GeyserServerSession.java:75)
        at org.geysermc.connector.network.session.UpstreamSession.sendPacket(UpstreamSession.java:45)
        at org.geysermc.connector.network.session.GeyserSession.lambda$sendUpstreamPacket$4(GeyserSession.java:827)
        at org.geysermc.connector.event.EventResult.onNotCancelled(EventResult.java:59)
        at org.geysermc.connector.network.session.GeyserSession.sendUpstreamPacket(GeyserSession.java:825)
        at org.geysermc.connector.network.translators.java.JavaTitleTranslator.translate(JavaTitleTranslator.java:77)
        at org.geysermc.connector.network.translators.java.JavaTitleTranslator.translate(JavaTitleTranslator.java:36)
        at org.geysermc.connector.network.translators.PacketTranslatorRegistry.translate(PacketTranslatorRegistry.java:100)
        at org.geysermc.connector.network.session.GeyserSession.handleDownstreamPacket(GeyserSession.java:603)
        at org.geysermc.connector.network.session.GeyserSession$1.packetReceived(GeyserSession.java:551)
        at com.github.steveice10.packetlib.event.session.PacketReceivedEvent.call(PacketReceivedEvent.java:51)
        at com.github.steveice10.packetlib.tcp.TcpSession.callEvent(TcpSession.java:149)
        at com.github.steveice10.packetlib.tcp.TcpSession$3.run(TcpSession.java:324)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.NullPointerException: string
        at com.nukkitx.network.util.Preconditions.checkNotNull(Preconditions.java:880)
        at com.nukkitx.protocol.bedrock.BedrockPacketHelper.writeString(BedrockPacketHelper.java:274)
        at com.nukkitx.protocol.bedrock.v291.serializer.SetTitleSerializer_v291.serialize(SetTitleSerializer_v291.java:19)
        at com.nukkitx.protocol.bedrock.v291.serializer.SetTitleSerializer_v291.serialize(SetTitleSerializer_v291.java:11)
        at com.nukkitx.protocol.bedrock.BedrockPacketSerializer.serialize(BedrockPacketSerializer.java:13)
        at com.nukkitx.protocol.bedrock.BedrockPacketCodec.tryEncode(BedrockPacketCodec.java:80)
        ... 14 more
@bundabrg
Copy link
Owner Author

This may be because of my Bleeding fork. More testing needed.

bundabrg added a commit to bundabrg/Geyser that referenced this issue Feb 17, 2021
@bundabrg
Fix NPE when a TitlePacket of type TIMES is sent
5ddc23a 
References: bundabrg/GeyserReversion#29
@bundabrg
Copy link
Owner Author

Upstream issue.

@bundabrg bundabrg mentioned this issue Feb 17, 2021
Merged
Camotoy pushed a commit to GeyserMC/Geyser that referenced this issue Feb 17, 2021
@bundabrg
Fix NPE when a TitlePacket of type TIMES is sent (#1944)
15027c2 
References: bundabrg/GeyserReversion#29

Co-authored-by: bundabrg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bundabrg