Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): generate docker images on tag/push #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(docker): generate docker images on tag/push #41

wants to merge 4 commits into from

Conversation

Falci
Copy link

@Falci Falci commented Jul 26, 2022

Every merge to master will generate a lnme:edge image.
Every tag will:

  • update lnme:latest
  • generate a new lnme:<tag>

#39

@bumi
Copy link
Owner

bumi commented Aug 1, 2022

thanks @Falci for the PR!
@AaronDewes you had done this before. any comments?

AaronDewes
AaronDewes reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but looks good to me otherwise

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
@bumi
Copy link
Owner

bumi commented Aug 11, 2022

thanks @AaronDewes for the feedback!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronDewes AaronDewes AaronDewes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Falci @bumi @AaronDewes