Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cart.php, fix CartItem::fromAttributes call #5

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Update Cart.php, fix CartItem::fromAttributes call #5

merged 3 commits into from
Apr 16, 2019

Conversation

PazkaL
Copy link

@PazkaL PazkaL commented Mar 29, 2019

The CartItem::fromAttributes call is missing the $weight parameter, and the CartItemOptions don't work any more because of this.

The CartItem::fromAttributes call is missing the $weight parameter, and the CartItemOptions don't work any more because of this.
@bumbummen99
Copy link
Owner

bumbummen99 commented Apr 15, 2019

Sorry for the inactivity, i'll take a look into it but as far it is looking fine. I'll merge asap

@bumbummen99
Copy link
Owner

@PazkaL While this will fix the issues with the CartIemOptions due to the misused signature, there are some more changes needed in order to make the weight feature work correctly as described in the readme. Could you please enable write access for me so i make these changes to the pull request before merging?

Here is an article describing how to allow access to your pull requests to the projects maintainers.

@PazkaL
Copy link
Author

PazkaL commented Apr 16, 2019

Hi @bumbummen99 "Allow edits from maintainers" is enabled!

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #5   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      134    134           
=======================================
  Files             5      5           
  Lines           353    353           
=======================================
  Hits            353    353
Impacted Files Coverage Δ Complexity Δ
src/Cart.php 100% <100%> (ø) 82 <7> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9b470...f467314. Read the comment docs.

@bumbummen99
Copy link
Owner

@PazkaL Thanks! I made the necessary changes, the add method should now be in line with the information from the readme file. Please keep in mind that the signature of the 'add' method has now changed
function add($id, $name = null, $qty = null, $price = null, $weight = null, array $options = [])
This change should have already been in 5d117a0, i am sorry for any inconveniences.

@bumbummen99 bumbummen99 merged commit e21c2e9 into bumbummen99:master Apr 16, 2019
@PazkaL PazkaL deleted the patch-1 branch September 13, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants